-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Added 32-bit build #27274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 32-bit build #27274
Conversation
This will be really nice to get in place. Looks like a problem with conda |
This would need to be on Windows if we wanted it right? Think Linux / macOS are 64 bit only for Conda: |
Anaconda (and IIRC Conda-forge) stopped building 32-bit linux packages last
year IIRC so it's not too surprising this failed.
The CI failure in pandas-wheels was 32-bit linux. Ideally we would test
both. This approach may work for win-32.
I think to properly test linux-32, we'll need to install numpy from PyPI.
It's possible 32-bit linux can install noarch packages. Need to verify.
But the blocker here is probably reporting that `conda update conda` is
broken upstream. Haven't had time though.
…On Mon, Jul 8, 2019 at 1:40 PM William Ayd ***@***.***> wrote:
This would need to be on Windows if we wanted it right? Think Linux /
macOS are 64 bit only for Conda:
https://docs.anaconda.com/anaconda/packages/pkg-docs/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27274?email_source=notifications&email_token=AAKAOITU6Z7VYFQUKSIUZ4DP6OCYXA5CNFSM4H6VTDCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZN7PLQ#issuecomment-509343662>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOITOG2GQF2TBVT7BBWDP6OCYXANCNFSM4H6VTDCA>
.
|
It wouldn't be part of the CI, but I could set up a raspi to run the test suite as part of a nightly build |
We have some 32 bit checks already in the script: Line 28 in c64c9cb
Maybe extend that to skip the update? |
@jreback @jbrockmendel, can you give any pointers on this compilation failure?
|
Hmm https://stackoverflow.com/a/45971022 isn't promising. |
I guess an issue with the overall platform? |
OK, it seems to be working now. I'm using the conda compilers (just for 32-bit right now. May want to consider for other builds too. I don't know). 71f791e has the fix for the issue we discovered during the release (#27227). These are the expected dtypes on master. >>> gr = pd.Series([1]).groupby([0])
>>> gr.grouper.group_info[0].dtype
dtype('int64')
>>> gr.grouper.group_info[1].dtype
dtype('int32') |
FYI, I think we should provide a Dockerfile to help contributors debug 32-bit issues. I don't know what the best practices are for writing / using Dockerfiles for development environments. |
thanks @TomAugspurger really nice! |
Closes #19694
Closes #27227