Skip to content

Added 32-bit build #27274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2019
Merged

Added 32-bit build #27274

merged 7 commits into from
Jul 15, 2019

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Jul 7, 2019

Closes #19694
Closes #27227

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jul 7, 2019
@jbrockmendel
Copy link
Member

This will be really nice to get in place. Looks like a problem with conda

@jreback jreback added the Build Library building on various platforms label Jul 8, 2019
@WillAyd
Copy link
Member

WillAyd commented Jul 8, 2019

This would need to be on Windows if we wanted it right? Think Linux / macOS are 64 bit only for Conda:

https://docs.anaconda.com/anaconda/packages/pkg-docs/

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jul 8, 2019 via email

@jbrockmendel
Copy link
Member

It wouldn't be part of the CI, but I could set up a raspi to run the test suite as part of a nightly build

@WillAyd
Copy link
Member

WillAyd commented Jul 8, 2019

We have some 32 bit checks already in the script:

if [[ "$BITS32" == "yes" ]]; then

Maybe extend that to skip the update?

@TomAugspurger
Copy link
Contributor Author

@jreback @jbrockmendel, can you give any pointers on this compilation failure?

gcc -pthread -B /home/vsts/miniconda3/envs/pandas-dev/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DNPY_NO_DEPRECATED_API=0 -I./pandas/_libs -Ipandas/_libs/src/klib -Ipandas/_libs/src -I/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/numpy/core/include -I/home/vsts/miniconda3/envs/pandas-dev/include/python3.6m -c pandas/_libs/algos.c -o build/temp.linux-x86_64-3.6/pandas/_libs/algos.o -Wno-unused-function
In file included from /home/vsts/miniconda3/envs/pandas-dev/include/python3.6m/Python.h:53:0,
                 from pandas/_libs/algos.c:44:
/home/vsts/miniconda3/envs/pandas-dev/include/python3.6m/pyport.h:686:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
 #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
  ^

@TomAugspurger
Copy link
Contributor Author

Hmm https://stackoverflow.com/a/45971022 isn't promising.

@WillAyd
Copy link
Member

WillAyd commented Jul 15, 2019

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jul 15, 2019

OK, it seems to be working now. I'm using the conda compilers (just for 32-bit right now. May want to consider for other builds too. I don't know).

71f791e has the fix for the issue we discovered during the release (#27227). These are the expected dtypes on master.

>>> gr = pd.Series([1]).groupby([0])
>>> gr.grouper.group_info[0].dtype
dtype('int64')
>>> gr.grouper.group_info[1].dtype
dtype('int32')

@TomAugspurger
Copy link
Contributor Author

FYI, I think we should provide a Dockerfile to help contributors debug 32-bit issues. I don't know what the best practices are for writing / using Dockerfiles for development environments.

@jreback jreback merged commit d4e2734 into pandas-dev:master Jul 15, 2019
@jreback
Copy link
Contributor

jreback commented Jul 15, 2019

thanks @TomAugspurger really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel build failing BLD: add 32-bit buid
4 participants