Skip to content

DOC: Clarify column type for 'on' parameter of rolling #27265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2019
Merged

DOC: Clarify column type for 'on' parameter of rolling #27265

merged 3 commits into from
Jul 8, 2019

Conversation

ihsansecer
Copy link
Contributor

@WillAyd
Copy link
Member

WillAyd commented Jul 7, 2019

Might be reading it wrong but not sure about the referenced issue. Commented there

jreback
jreback requested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather say that the 'on' argument is ignore for for an integer window argument.

@jreback jreback added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 8, 2019
@ihsansecer
Copy link
Contributor Author

ihsansecer commented Jul 8, 2019 •
edited
Loading

@WillAyd I believe he is confused if an integer column can be used while calculating rolling window

@jreback jreback added this to the 0.25.0 milestone Jul 8, 2019
@jreback jreback merged commit 3c78b2f into pandas-dev:master Jul 8, 2019
@jreback
Copy link
Contributor

jreback commented Jul 8, 2019

thanks @ihsansecer

@ihsansecer ihsansecer deleted the gh21687 branch July 11, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

"on" argument of DataFrame.rolling only works for datetime columns
3 participants
@ihsansecer @WillAyd @jreback