BUG: Enable changing dtype of column where column names are not unique #27256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ique and columns being assinged to will be overwritten and change type.
gfyoung
added
Dtype Conversions
jreback
requested changes
Jul 6, 2019
| @@ -1075,6 +1075,12 @@ def value_getitem(placement): | |||
| blknos = self._blknos[loc] | |||
| blklocs = self._blklocs[loc].copy() | |||
|
|
|||
| if not self.axes[0].is_unique: | |||
There was a problem hiding this comment.
really don't want to add anything in internals; why is this not possible to be done in pandas/core/indexing?
There was a problem hiding this comment.
@jreback agreed, thanks for feedback! This is work in progress. I'll try to fix it in pandas/core/indexing.
|
@rok is this still active? |
|
@WillAyd yeah, I still plan to do this but have to make time. If I'm blocking anything please let me know. :) |
|
closing as stale, though we'd still like this when you can comeback; ping to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff