BUG: merge_asof with multiple by columns with tz #27243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Reshaping
|
thanks @mroeschke |
| @@ -1686,6 +1686,9 @@ def _get_join_indexers(self): | |||
|
|
|||
| def flip(xs): | |||
| """ unlike np.transpose, this returns an array of tuples """ | |||
| xs = [ | |||
| x if not is_extension_array_dtype(x) else x._ndarray_values for x in xs | |||
| ] | |||
There was a problem hiding this comment.
@mroeschke can you comment on why _ndarray_values was chosen here? does it matter that its really lossy for e.g. PeriodIndex?
There was a problem hiding this comment.
I don't recall. I think _values or some equivalent would be okay here
| expected.index = result.index | ||
| # time column appears after left's columns | ||
| # time column appears after left"s columns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff