Skip to content

BUG: Fix Series divmod #26987 #27130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

BUG: Fix Series divmod #26987 #27130

wants to merge 2 commits into from

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jun 29, 2019 •
edited
Loading

jreback
jreback requested changes Jul 2, 2019
View reviewed changes
pandas/core/missing.py
if mask.any():
res2[mask] = np.nan
return res1, res2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do thi brlow line 546 you may not need to duplicate code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it ends up being a wash because we have to do these checks in multiple places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the style of this change is not consistent with the rest of the function, it could be better integrated, for example a helper function would go a long way here.

@jreback jreback added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jul 2, 2019
This was referenced Jul 5, 2019
Merged
Closed
Merged
@jbrockmendel
Copy link
Member Author

@TomAugspurger I'm running into issues in this branch calling np.putmask on a SparseArray. Is there an alternative for that?

@jreback
Copy link
Contributor

jreback commented Jul 5, 2019

merge master here

@jbrockmendel
Copy link
Member Author

merge master here

Still troubleshooting SparseArray and IntegerArray failures locally.

@jbrockmendel
Copy link
Member Author

Closing in favor of #27239; SparseArray putmask needs to be figured out before this branch can go anywhere.

@jbrockmendel jbrockmendel deleted the fill_zeros_divmod branch April 5, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError with divmod(Series, Series) with 0 in the denominator
2 participants
@jbrockmendel @jreback