Slicing an index with DateTime throws AttributeError: 'int' object has no attribute 'stop' #27127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH26944 AttributeError on partial multiindex timestamp slice
Codecov Report
@@ Coverage Diff @@
## master #27127 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 180 180
Lines 50864 50866 +2
==========================================
- Hits 46731 46729 -2
- Misses 4133 4137 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #27127 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 180 180
Lines 50864 50819 -45
==========================================
- Hits 46731 46687 -44
+ Misses 4133 4132 -1
Continue to review full report at Codecov.
|
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test.
|
Hello @soilstack! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-01 15:42:06 UTC |
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 correction.
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections.
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections w293, w391.
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections w293, w391. Simplified test code.
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections w293, w391. Simplified test code. E501
done |
|
oops accidentally closed |
mroeschke
reviewed
Jun 30, 2019
jreback
changed the title
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections w293, w391. Simplified test code. E501. changed assertion method.
Fixes GH26944 AttributeError on partial multiindex timestamp slice and includes test and PEP8 corrections w293, w391. Simplified test code. E501. changed assertion method. more pep8 violations.
mroeschke
approved these changes
Jul 1, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH26944 AttributeError on partial multiindex timestamp slice
git diff upstream/master -u -- "*.py" | flake8 --diff