Skip to content

Regenerated Excel files to Suppress Openpyxl Warnings #27122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 29, 2019

As noticed by @jorisvandenbossche openpyxl was throwing some warnings for excel files in the test suite. The warnings did not appear relevant to the data within the files and are most likely historical artifacts of how the files were created. Simply resaving these removes the warning from the builds

pandas/tests/io/excel/test_readers.py::TestReaders::test_reader_special_dtypes[openpyxl-.xlsx]
pandas/tests/io/excel/test_readers.py::TestReaders::test_reader_special_dtypes[openpyxl-.xlsm]
pandas/tests/io/excel/test_readers.py::TestReaders::test_reading_all_sheets[openpyxl-.xlsx]
pandas/tests/io/excel/test_readers.py::TestReaders::test_reading_all_sheets[openpyxl-.xlsm]
pandas/tests/io/excel/test_readers.py::TestReaders::test_reading_multiple_specific_sheets[openpyxl-.xlsx]
pandas/tests/io/excel/test_readers.py::TestReaders::test_reading_multiple_specific_sheets[openpyxl-.xlsm]
pandas/tests/io/excel/test_readers.py::TestReaders::test_read_excel_squeeze[openpyxl-.xlsx]
pandas/tests/io/excel/test_readers.py::TestReaders::test_read_excel_squeeze[openpyxl-.xlsm]
pandas/tests/io/excel/test_readers.py::TestExcelFileRead::test_excel_passes_na[openpyxl-.xlsx]
pandas/tests/io/excel/test_readers.py::TestExcelFileRead::test_excel_passes_na[openpyxl-.xlsm]
  /Users/williamayd/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/openpyxl/worksheet/_reader.py:296: UserWarning: Unknown extension is not supported and will be removed

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite CI Continuous Integration IO Excel read_excel, to_excel labels Jun 29, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Jun 29, 2019
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, can confirm the warnings are gone

@WillAyd WillAyd merged commit ddec4eb into pandas-dev:master Jun 30, 2019
@WillAyd WillAyd deleted the openpyxl-test-warnings branch June 30, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants