Bump python_requires to 3.5.3 #27116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should change to 3.5.2? |
|
Hmm based off error in Linux compat might even need a bump to 3.5.3 per python/typing#267 giving that a look now |
jorisvandenbossche
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned during sprint today some of the typing constructs we use were not added until Python 3.5.2, specifically typing.Type and typing.DefaultDict and maybe at some point typing.TYPE_CHECKING
https://docs.python.org/3/library/typing.html#typing.Type
This is a bump of the setup files and docs to 3.5.2.