BUG: Fix handling of ambiguous or nonexistent of start and end times in date_range #27088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 27, 2019 15:38
mroeschke
changed the title
jreback
reviewed
Jun 28, 2019
| @@ -2133,6 +2136,8 @@ def _maybe_localize_point(ts, is_none, is_not_none, freq, tz): | |||
| is_not_none : argument that should not be None | |||
| freq : Tick, DateOffset, or None | |||
| tz : str, timezone object or None | |||
There was a problem hiding this comment.
of u feel like typing the args here would be great (or follow up done too)
|
lgtm. @mroeschke if you want to add some types great, otherwise pls merge. |
|
Thanks. Will add typing in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffClosing a
FIXMEnote in the test suite.