Removed Panel Kludge from Pickle/Msgpack tests #27082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
added
Testing
jreback
requested changes
Jun 27, 2019
| if _loose_version >= LooseVersion('0.18'): | ||
| from pandas import RangeIndex | ||
| index['range'] = RangeIndex(10) | ||
| from pandas import RangeIndex |
There was a problem hiding this comment.
can move this import to the top i think
|
need a note for mspack as well. |
WillAyd
commented
Jun 27, 2019
jreback
requested changes
Jun 27, 2019
doc/source/whatsnew/v0.25.0.rst
Outdated
| .. warning:: | ||
|
|
||
| ``read_pickle`` and ``read_msgpack`` are only guaranteed backwards compatible back to | ||
| pandas version 0.20.3 |
There was a problem hiding this comment.
can you add the issue number reference here
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -13,6 +13,11 @@ What's New in 0.25.0 (April XX, 2019) | |||
| `Panel` has been fully removed. For N-D labeled data structures, please | |||
| use `xarray <https://xarray.pydata.org/en/stable/>`_ | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| ``read_pickle`` and ``read_msgpack`` are only guaranteed backwards compatible back to | |||
There was a problem hiding this comment.
can you add the :func:`read_pickle` and same for msgpack
| @@ -13,6 +13,11 @@ What's New in 0.25.0 (April XX, 2019) | |||
| `Panel` has been fully removed. For N-D labeled data structures, please | |||
| use `xarray <https://xarray.pydata.org/en/stable/>`_ | |||
|
|
|||
| .. warning:: | |||
There was a problem hiding this comment.
also add this note in io.rst (or similar, doesn't need the issue number)
jreback
approved these changes
Jun 27, 2019
|
thanks @WillAyd |
This was referenced Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jreback @jbrockmendel
Recreated pickle file for 0.20.3 using Python 3.5.2 on Mac. Created msgpack file anew (previously 0.19 was last version tested)
Lots of follow ups can be done here including:
Can also add more platforms / versions here as required but this should be a good starting point