Skip to content

Typing: Support New Mypy Semantic Analyzer #27070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 8, 2019
Merged

Typing: Support New Mypy Semantic Analyzer #27070

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f64719c
Add semantic analyser
alimcmaster1 Jun 30, 2019
1c8ceda
Remove already def errors
alimcmaster1 Jun 30, 2019
0dc57ef
Convert __init__ structure to match io.excel
alimcmaster1 Jun 30, 2019
7e1681e
Add back noqa and add __all__
alimcmaster1 Jun 30, 2019
a961e65
Add back noqa and add __all__
alimcmaster1 Jun 30, 2019
0cfc9f2
Add back noqa and add __all__
alimcmaster1 Jun 30, 2019
29acba4
Remove mypy version requirements
alimcmaster1 Jul 2, 2019
d5f5845
Merge branch 'master' into PR_TOOL_MERGE_PR_27070
jreback Jul 3, 2019
a29e245
Merge branch 'master' of https://github.com/alimcmaster1/pandas into …
alimcmaster1 Jul 5, 2019
6ae4040
__all__ as strings
alimcmaster1 Jul 5, 2019
3a744b4
black formatting
alimcmaster1 Jul 5, 2019
917135c
fix import
alimcmaster1 Jul 5, 2019
0b34836
Rename method
alimcmaster1 Jul 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pandas/core/arrays/interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@
"""),
))
class IntervalArray(IntervalMixin, ExtensionArray):
dtype = IntervalDtype()
ndim = 1
can_hold_na = True
_na_value = _fill_value = np.nan
Expand Down
1 change: 0 additions & 1 deletion pandas/core/indexes/timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ def _join_i8_wrapper(joinf, **kwargs):

_freq = None

_box_func = TimedeltaArray._box_func
_bool_ops = TimedeltaArray._bool_ops
_object_ops = TimedeltaArray._object_ops
_field_ops = TimedeltaArray._field_ops
Expand Down
15 changes: 11 additions & 4 deletions pandas/io/json/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
from .json import dumps, loads, read_json, to_json # noqa
from .normalize import json_normalize # noqa
from .table_schema import build_table_schema # noqa
from pandas.io.json._json import dumps, loads, read_json, to_json
from pandas.io.json._normalize import json_normalize
from pandas.io.json._table_schema import build_table_schema

del json, normalize, table_schema # noqa
__all__ = [
dumps,
loads,
read_json,
to_json,
json_normalize,
build_table_schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those should be strings I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

]
4 changes: 2 additions & 2 deletions pandas/io/json/json.py → pandas/io/json/_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
from pandas.io.formats.printing import pprint_thing
from pandas.io.parsers import _validate_integer

from .normalize import _convert_to_line_delimits
from .table_schema import build_table_schema, parse_table_schema
from ._normalize import _convert_to_line_delimits
from ._table_schema import build_table_schema, parse_table_schema

loads = json.loads
dumps = json.dumps
Expand Down
0 pandas/io/json/normalize.py → pandas/io/json/_normalize.py
View file
Open in desktop
File renamed without changes.
0 pandas/io/json/table_schema.py → pandas/io/json/_table_schema.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion pandas/tests/io/json/test_json_table_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from pandas import DataFrame
import pandas.util.testing as tm

from pandas.io.json.table_schema import (
from pandas.io.json._table_schema import (
as_json_table_type, build_table_schema, convert_json_field_to_pandas_type,
convert_pandas_type_to_json_field, set_default_names)

Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/io/json/test_normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import pandas.util.testing as tm

from pandas.io.json import json_normalize
from pandas.io.json.normalize import nested_to_record
from pandas.io.json._normalize import nested_to_record


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/io/json/test_readlines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from pandas.util.testing import (
assert_frame_equal, assert_series_equal, ensure_clean)

from pandas.io.json.json import JsonReader
from pandas.io.json._json import JsonReader


@pytest.fixture
Expand Down