-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
COMPAT: 32-bit nargsort #27064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: 32-bit nargsort #27064
Conversation
Getting failures like
|
@@ -53,8 +53,8 @@ def test_argsort_missing(self, data_missing_for_sorting): | |||
self.assert_series_equal(result, expected) | |||
|
|||
@pytest.mark.parametrize('na_position, expected', [ | |||
('last', np.array([2, 0, 1], dtype='int64')), | |||
('first', np.array([1, 2, 0], dtype='int64')) | |||
('last', np.array([2, 0, 1], dtype='int')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this is failing on windows, maybe you need intp here?
Codecov Report
@@ Coverage Diff @@
## master #27064 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 180 180
Lines 50714 50713 -1
==========================================
- Hits 46679 46677 -2
- Misses 4035 4036 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #27064 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 180 180
Lines 50714 50713 -1
==========================================
- Hits 46679 46677 -2
- Misses 4035 4036 +1
Continue to review full report at Codecov.
|
thanks @TomAugspurger |
xref MacPython/pandas-wheels#51