Skip to content

Install pyreadstat using conda instead #27061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

rs2
Copy link
Contributor

@rs2 rs2 commented Jun 26, 2019

> conda search pyreadstat -c conda-forge
Loading channels: done
# Name                       Version           Build  Channel
pyreadstat                     0.2.1  py36h301d43c_0  conda-forge
pyreadstat                     0.2.1  py37h301d43c_0  conda-forge
pyreadstat                     0.2.5  py36h301d43c_0  conda-forge
pyreadstat                     0.2.5  py37h301d43c_0  conda-forge
pyreadstat                     0.2.6  py36h301d43c_0  conda-forge
pyreadstat                     0.2.6  py37h301d43c_0  conda-forge
  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

```
> conda search pyreadstat -c conda-forge
Loading channels: done
# Name                       Version           Build  Channel
pyreadstat                     0.2.1  py36h301d43c_0  conda-forge
pyreadstat                     0.2.1  py37h301d43c_0  conda-forge
pyreadstat                     0.2.5  py36h301d43c_0  conda-forge
pyreadstat                     0.2.5  py37h301d43c_0  conda-forge
pyreadstat                     0.2.6  py36h301d43c_0  conda-forge
pyreadstat                     0.2.6  py37h301d43c_0  conda-forge
```
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jun 26, 2019

Can you run python scripts/generate_pip_deps_from_conda.py too?

edit: actually never mind. It may be identical.

@rs2
Copy link
Contributor Author

rs2 commented Jun 26, 2019

@TomAugspurger 👍

@marcelotrevisani
Copy link

related to #27062

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #27061 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27061      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         180      180              
  Lines       50713    50713              
==========================================
- Hits        46680    46677       -3     
- Misses       4033     4036       +3
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 41.88% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff50b46...80ebc62. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #27061 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27061      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         180      180              
  Lines       50713    50713              
==========================================
- Hits        46680    46677       -3     
- Misses       4033     4036       +3
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 41.88% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff50b46...80ebc62. Read the comment docs.

@TomAugspurger
Copy link
Contributor

Thanks @rs2

@TomAugspurger TomAugspurger merged commit 19d5d53 into pandas-dev:master Jun 26, 2019
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 26, 2019
@TomAugspurger TomAugspurger added the Dependencies Required and optional dependencies label Jun 26, 2019
@datapythonista
Copy link
Member

The rest of the dependencies in that section are sorted alphabetically, if you want to resort in a follow up, that would keep things consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants