CLN: Remove no-longer-used BlockManager.xs

[jbrockmendel]

Also some unrecheable try_cast code.

[codecov]

Codecov Report

Merging #27043 into master will increase coverage by 1.39%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #27043      +/-   ##
==========================================
+ Coverage   90.64%   92.04%   +1.39%     
==========================================
  Files         180      180              
  Lines       50754    50713      -41     
==========================================
+ Hits        46005    46677     +672     
+ Misses       4749     4036     -713

Flag	Coverage Δ
#multiple	90.68% <100%> (+0.03%)	⬆️
#single	41.88% <0%> (?)

Impacted Files	Coverage Δ
pandas/core/internals/managers.py	96.86% <ø> (+0.76%)	⬆️
pandas/core/panel.py	17.8% <ø> (+0.19%)	⬆️
pandas/core/internals/blocks.py	95.14% <100%> (+0.52%)	⬆️
pandas/util/testing.py	90.94% <0%> (+0.1%)	⬆️
pandas/core/arrays/categorical.py	95.92% <0%> (+0.12%)	⬆️
pandas/core/indexes/datetimes.py	96.37% <0%> (+0.16%)	⬆️
pandas/io/formats/printing.py	86.72% <0%> (+0.94%)	⬆️
pandas/io/clipboard/clipboards.py	34.78% <0%> (+2.89%)	⬆️
pandas/core/computation/expr.py	97.8% <0%> (+3.02%)	⬆️
pandas/core/computation/common.py	89.47% <0%> (+5.26%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9182df...9432501. Read the comment docs.

[codecov]

Codecov Report

Merging #27043 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #27043      +/-   ##
==========================================
+ Coverage   92.01%   92.04%   +0.03%     
==========================================
  Files         180      180              
  Lines       50754    50713      -41     
==========================================
- Hits        46699    46677      -22     
+ Misses       4055     4036      -19

Flag	Coverage Δ
#multiple	90.68% <100%> (+0.03%)	⬆️
#single	41.85% <0%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/core/internals/managers.py	96.86% <ø> (+0.76%)	⬆️
pandas/core/panel.py	17.8% <ø> (+0.19%)	⬆️
pandas/core/internals/blocks.py	95.14% <100%> (+0.52%)	⬆️
pandas/io/gbq.py	88.88% <0%> (-11.12%)	⬇️
pandas/core/frame.py	96.89% <0%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f1d69...8fc4307. Read the comment docs.

[TomAugspurger]

Is this code hit? I'm confused by the reference to panel.

[jbrockmendel]

We've removed most of the Panel tests, but not yet all of Panel itself. So this is just explicitly-disabling a method that would call BlockManager.xs, since we're on the road towards removing the class anyway.

[jbrockmendel]

CI fail looks like a conda problem

[TomAugspurger]

#26595 fixes it.

…

On Tue, Jun 25, 2019 at 10:36 PM jbrockmendel ***@***.***> wrote: CI fail looks like a conda problem — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#27043?email_source=notifications&email_token=AAKAOIXBUYYTBAJZ5CLEXNDP4LP5XA5CNFSM4H3MG4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYSHAWY#issuecomment-505704539>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIQYOAMY7S4DA6K3ALDP4LP5XANCNFSM4H3MG4HA> .

[jreback]

lgtm, pls merge master and ping on green.

[jbrockmendel]

ping