Skip to content

PKG: Add test extra #27039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2019
Merged

PKG: Add test extra #27039

merged 2 commits into from
Jun 26, 2019

Conversation

TomAugspurger
Copy link
Contributor

Closes #25593

jreback
jreback reviewed Jun 25, 2019
View reviewed changes
setup.py
@@ -784,4 +784,11 @@ def srcpath(name=None, suffix='.pyx', subdir='src'):
classifiers=CLASSIFIERS,
platforms='any',
python_requires='>=3.5',
extras_require={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-xdist should also be here i think

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27039 into master will increase coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27039      +/-   ##
==========================================
+ Coverage   90.64%      92%   +1.35%     
==========================================
  Files         180      180              
  Lines       50754    50754              
==========================================
+ Hits        46005    46694     +689     
+ Misses       4749     4060     -689
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 41.83% <ø> (?)
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.92% <0%> (+0.12%) ⬆️
pandas/core/indexes/datetimes.py 96.37% <0%> (+0.16%) ⬆️
pandas/io/formats/printing.py 86.72% <0%> (+0.94%) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <0%> (+2.89%) ⬆️
pandas/core/computation/expr.py 97.8% <0%> (+3.02%) ⬆️
pandas/core/computation/common.py 89.47% <0%> (+5.26%) ⬆️
pandas/io/pytables.py 90.3% <0%> (+25.43%) ⬆️
pandas/core/computation/pytables.py 90.24% <0%> (+27.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9182df...5b9941c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019 •
edited
Loading

Codecov Report

Merging #27039 into master will increase coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27039      +/-   ##
==========================================
+ Coverage   90.64%      92%   +1.35%     
==========================================
  Files         180      180              
  Lines       50754    50754              
==========================================
+ Hits        46005    46695     +690     
+ Misses       4749     4059     -690
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 41.85% <ø> (?)
Impacted Files Coverage Δ
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/arrays/categorical.py 95.92% <0%> (+0.12%) ⬆️
pandas/core/indexes/datetimes.py 96.37% <0%> (+0.16%) ⬆️
pandas/io/formats/printing.py 86.72% <0%> (+0.94%) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <0%> (+2.89%) ⬆️
pandas/core/computation/expr.py 97.8% <0%> (+3.02%) ⬆️
pandas/core/computation/common.py 89.47% <0%> (+5.26%) ⬆️
pandas/io/pytables.py 90.3% <0%> (+25.43%) ⬆️
pandas/core/computation/pytables.py 90.24% <0%> (+27.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9182df...901bc52. Read the comment docs.

@gfyoung gfyoung added Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite labels Jun 26, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 26, 2019
@jreback jreback merged commit b4aa1d6 into pandas-dev:master Jun 26, 2019
@jreback
Copy link
Contributor

jreback commented Jun 26, 2019

thanks @TomAugspurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Add extras_require for tests dependencies in setup.py
3 participants
@TomAugspurger @jreback @gfyoung