-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API/REGR: Convert to float for index union #27034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API/REGR: Convert to float for index union #27034
Conversation
This restores the 0.24.x behavior of Index.union(other) between Float and (U)Int indexes. These are now floating dtype. left | right | output of left.union(right) ----- | ----- | ------ int |float | float64 int |uint | object float | uint | float64 pandas-dev#26778 (comment) Closes pandas-dev#26778
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. can you add a sub-section in whatsnew to explain the change.
+1 on the actual change semantics.
Codecov Report
@@ Coverage Diff @@
## master #27034 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 180 180
Lines 50774 50799 +25
==========================================
+ Hits 46711 46733 +22
- Misses 4063 4066 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #27034 +/- ##
==========================================
- Coverage 92.04% 92% -0.04%
==========================================
Files 180 180
Lines 50714 50765 +51
==========================================
+ Hits 46679 46706 +27
- Misses 4035 4059 +24
Continue to review full report at Codecov.
|
This is restoring the 0.24.2 behavior. I added a note in the user guide docs. |
That may be, but this should be up front about that in the whatsnew. IOW should be highly visible. |
The CI failure from codecov is unrelated I think (cc @mroeschke. May just be a hiccup) |
thanks @TomAugspurger |
This restores the 0.24.x behavior of Index.union(other) between
Float and (U)Int indexes. These are again floating dtype.
#26778 (comment)
Closes #26778