Skip to content

API/REGR: Convert to float for index union #27034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2019

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Jun 25, 2019

This restores the 0.24.x behavior of Index.union(other) between
Float and (U)Int indexes. These are again floating dtype.

left right output of left.union(right)
int float float64
int uint object
float uint float64

#26778 (comment)

Closes #26778

This restores the 0.24.x behavior of Index.union(other) between
Float and (U)Int indexes. These are now floating dtype.

left  | right | output of left.union(right)
----- | ----- | ------
int   |float  | float64
int   |uint   | object
float | uint  | float64

pandas-dev#26778 (comment)

Closes pandas-dev#26778
@TomAugspurger TomAugspurger added Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses labels Jun 25, 2019
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 25, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you add a sub-section in whatsnew to explain the change.

+1 on the actual change semantics.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27034 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27034      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50799      +25     
==========================================
+ Hits        46711    46733      +22     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.85% <46.15%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/numeric.py 97.6% <100%> (+0.26%) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...134a547. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27034 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27034      +/-   ##
==========================================
- Coverage   92.04%      92%   -0.04%     
==========================================
  Files         180      180              
  Lines       50714    50765      +51     
==========================================
+ Hits        46679    46706      +27     
- Misses       4035     4059      +24
Flag Coverage Δ
#multiple 90.64% <100%> (-0.04%) ⬇️
#single 41.83% <58.33%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/numeric.py 97.46% <100%> (+0.12%) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/internals/managers.py 96.09% <0%> (-0.77%) ⬇️
pandas/core/internals/blocks.py 94.61% <0%> (-0.53%) ⬇️
pandas/core/panel.py 17.61% <0%> (-0.2%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/indexing.py 93.48% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e955515...ca0d957. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

looks good. can you add a sub-section in whatsnew to explain the change.

This is restoring the 0.24.2 behavior. I added a note in the user guide docs.

@jreback
Copy link
Contributor

jreback commented Jun 25, 2019

looks good. can you add a sub-section in whatsnew to explain the change.

This is restoring the 0.24.2 behavior. I added a note in the user guide docs.

That may be, but this should be up front about that in the whatsnew. IOW should be highly visible.

@TomAugspurger
Copy link
Contributor Author

The CI failure from codecov is unrelated I think (cc @mroeschke. May just be a hiccup)

@jreback jreback merged commit b80df7b into pandas-dev:master Jun 27, 2019
@jreback
Copy link
Contributor

jreback commented Jun 27, 2019

thanks @TomAugspurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: Index.union preserve numerical index for range/float and int/float combinations
2 participants