Skip to content

TST: Fix flaky test #27010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2019
Merged

TST: Fix flaky test #27010

merged 2 commits into from
Jun 27, 2019

Conversation

jbrockmendel
Copy link
Member

Addresses one of the checkboxes in #26823

jreback
jreback requested changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u make these fixtures which will just fix this in a standard way

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #27010 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27010      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.83% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf74b02...32315d6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 23, 2019 •
edited
Loading

Codecov Report

Merging #27010 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27010      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46708       -3     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.85% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf74b02...ec2bf38. Read the comment docs.

@jbrockmendel
Copy link
Member Author

fixturized

jreback
jreback requested changes Jun 23, 2019
View reviewed changes
pandas/tests/resample/test_resample_api.py
@@ -14,10 +14,15 @@
end=datetime(2005, 1, 10), freq='Min')

test_series = Series(np.random.rand(len(dti)), dti)
test_frame = DataFrame(
_test_frame = DataFrame(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u just inline this in the fixture?

can u fixturize the series as well

not so sure these are great names either

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixturing this kind of thing is like pulling my own teeth. Closing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i can’t imagine it taking very long

@jbrockmendel jbrockmendel reopened this Jun 24, 2019
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail labels Jun 26, 2019
@jorisvandenbossche
Copy link
Member

Fix itself seems good, so merging

@jorisvandenbossche jorisvandenbossche merged commit f513191 into pandas-dev:master Jun 27, 2019
@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone Jun 27, 2019
@jbrockmendel jbrockmendel deleted the nuisance branch June 27, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @jorisvandenbossche @jreback @gfyoung