Skip to content

TST: fix flaky test #27004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

One of the tests that uses this fixture modifies its value, so the scope kwarg is incorrect. The failure depends on the order in which the test is run. AFAICT only showing up on OSX.

Hits one of the checkboxes in #26823.

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #27004 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27004      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46712    46708       -4     
- Misses       4062     4066       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.85% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d4ec5...6f2acdf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #27004 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27004      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46712    46708       -4     
- Misses       4062     4066       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.85% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d4ec5...6f2acdf. Read the comment docs.

@simonjayhawkins simonjayhawkins added the Unreliable Test Unit tests that occasionally fail label Jun 23, 2019
@simonjayhawkins simonjayhawkins merged commit e27eea8 into pandas-dev:master Jun 23, 2019
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the idx_unique branch June 23, 2019 16:10
@jbrockmendel jbrockmendel mentioned this pull request Jun 23, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants