Skip to content

DOC: df.astype example using dictionary #26994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2019

Conversation

stevennic
Copy link
Contributor

Closes #26990

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #26994 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26994      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.83% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.2% <ø> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14874f...c40836d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #26994 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26994      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.83% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.2% <ø> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14874f...c2d1702. Read the comment docs.

@WillAyd WillAyd added the Docs label Jun 22, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 22, 2019

Thanks! I think this looks good though caused some CI failures if you can take a look.

@datapythonista in case you have any input

@WillAyd WillAyd added this to the 0.25.0 milestone Jun 22, 2019
@stevennic
Copy link
Contributor Author

Yea the errors don't seem to be related to my changes:
Worker 'gw0' crashed while running 'pandas/tests/test_sorting.py::TestSafeSort::test_labels_out_of_bound[-1]'

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted to be sure but I agree probably unrelated so lgtm. @datapythonista @TomAugspurger if either of you want to take a look feel free to merge

@TomAugspurger TomAugspurger merged commit b4d4ec5 into pandas-dev:master Jun 22, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

@stevennic stevennic deleted the #26990 branch June 22, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show astype example with dict in docs
3 participants