Skip to content

CLN: move pytables tests to tests/io/pytables dir #26986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2019

Conversation

jgehrcke
Copy link
Contributor

This is a follow-up to this comment.

This moves two test modules (test_pytables.py and test_pytables_missing.py) into the new tests/io/pytables directory introduced in #26818.

@jreback let me know if I should create an issue for this first.

@jreback jreback added this to the 0.25.0 milestone Jun 21, 2019
@jreback jreback added IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite labels Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

@jgehrcke no issue needed for this, which is basically a pre-cursor for #18498

can you add an __init__.py (we traditionally do this for the test dirs) and ping on green.

@jgehrcke
Copy link
Contributor Author

can you add an init.py (we traditionally do this for the test dirs)

Now that you mentioned it three times I suppose it's time :-) Done.

@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

can you add an init.py (we traditionally do this for the test dirs)

Now that you mentioned it three times I suppose it's time :-) Done.

thanks!

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #26986 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26986      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba69f95...4792cb6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #26986 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26986      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba69f95...4792cb6. Read the comment docs.

@jreback jreback merged commit 171615a into pandas-dev:master Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

thanks @jgehrcke very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants