Skip to content

Assorted cleanups #26975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Assorted cleanups #26975

merged 1 commit into from
Jun 21, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #26975 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26975      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +<.01%     
==========================================
  Files         180      180              
  Lines       50746    50735      -11     
==========================================
- Hits        46623    46617       -6     
+ Misses       4123     4118       -5
Flag Coverage Δ
#multiple 90.47% <100%> (+0.01%) ⬆️
#single 41.12% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 96% <ø> (+0.78%) ⬆️
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd65e9...7f74905. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #26975 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26975      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +<.01%     
==========================================
  Files         180      180              
  Lines       50746    50735      -11     
==========================================
- Hits        46623    46617       -6     
+ Misses       4123     4118       -5
Flag Coverage Δ
#multiple 90.47% <100%> (+0.01%) ⬆️
#single 41.12% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 96% <ø> (+0.78%) ⬆️
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd65e9...7f74905. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #26975 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26975      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +<.01%     
==========================================
  Files         180      180              
  Lines       50746    50735      -11     
==========================================
- Hits        46623    46617       -6     
+ Misses       4123     4118       -5
Flag Coverage Δ
#multiple 90.47% <100%> (+0.01%) ⬆️
#single 41.12% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 96% <ø> (+0.78%) ⬆️
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd65e9...7f74905. Read the comment docs.

@jreback jreback added the Clean label Jun 21, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 21, 2019
@jreback jreback merged commit a4a18a9 into pandas-dev:master Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the misc branch June 21, 2019 00:56
@jbrockmendel jbrockmendel mentioned this pull request Jun 21, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants