-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DO NOT MERGE: Timing test files #26968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checking how long it takes every test file to see if some should be splitted for better parallelization I see this, which doesn't look right to me:
Didn't check the files individually, I guess in some cases we want to test loading big files, but 22 minutes to test the html I/O sounds very exaggerated. @pandas-dev/pandas-core is this expected? |
Did you try running that single file locally? |
No, wanted to check first that this is not expected and I'm missing something. If this doesn't seem right, I'll then try to figure out what's going on. |
The second one takes locally 4.6 seconds (and not almost 9 min). There are 2 out of 97 tests skipped (encoding related), of which one is an s3 test |
I'm seeing the two (not marked as slow) test_invalid_url tests as about 150s apiece. |
@datapythonista closable? |
Yep, let's close this for now, may need to reopen later to research on the timing problem, but I don't have time now. |
Checking how long every test file takes to run in the CI. In #26949 I'd like to run tests constraining that a whole file must be run in a single worker (so we can run
single
tests in parallel).This means that files that will take a lot of time won't be parallelized well, and should be splitted for this to work. So, I want to know how long each takes.