Skip to content

Docs: Capitalisation of title line changed to lower case #26942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

HolgerSpernau
Copy link

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

First letter of second or third word in the title changed to lower case letter.
In title line the first letter of the second or third word changed to non capital.
First letter of the second or third word changed to lower case.
First letter of the second or third word in the title line changed to lower case letter.
First letter of the second or third word in the title line updated to a lower case letter.
First letter of second word of header changed to lower case.
First letter of second word in header line changed to lower case.
@jorisvandenbossche
Copy link
Member

There is already somebody working on this: #26933
So best to first check how that overlaps (don't have time to check now, just quickly wanted to note that)

@gfyoung
Copy link
Member

gfyoung commented Jun 20, 2019

Closing in favor of #26950.

@HolgerSpernau : Thanks for your interest in contributing! Although this time you stumbled upon on issue that was already being worked on, there are plenty of other open issues where your help would be welcomed and appreciated!

@gfyoung gfyoung closed this Jun 20, 2019
@gfyoung gfyoung added the Duplicate Report Duplicate issue or pull request label Jun 20, 2019
@gfyoung gfyoung added this to the No action milestone Jun 20, 2019
@HolgerSpernau
Copy link
Author

@gfyoung : Thanks. I think the work I have done can still be used. I understood in #26933 that it is not only related to the first word in the header, but also the second or third words. That's what I concentrated on. Have a look again on the changed. Thanks.

@gfyoung
Copy link
Member

gfyoung commented Jun 20, 2019

@HolgerSpernau : That PR is for all words. In addition, we're going with as much title case (in general) as possible, whereas your PR goes for lowercase. Thanks for checking though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Report Duplicate issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants