Skip to content

Fix miscellaneous small holiday errors #26912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

gaibo
Copy link
Contributor

@gaibo gaibo commented Jun 17, 2019

Modified an incorrect comment on US Memorial Day and corrected some holiday names.
Nothing affects the code, only trying to contribute because I noticed some issues while reading through.

Modified an incorrect comment on Memorial Day and corrected some holiday names
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #26912 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26912      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50712    50712              
==========================================
- Hits        46590    46586       -4     
- Misses       4122     4126       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 41.09% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/holiday.py 93.1% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa77c3...c59f28c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #26912 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26912      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50712    50712              
==========================================
- Hits        46590    46586       -4     
- Misses       4122     4126       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 41.09% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/holiday.py 93.1% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa77c3...c59f28c. Read the comment docs.

@jreback jreback added the Docs label Jun 18, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 18, 2019
@jreback jreback merged commit d39a6de into pandas-dev:master Jun 18, 2019
@jreback
Copy link
Contributor

jreback commented Jun 18, 2019

thanks @gaibo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants