Add typing annotation to IntervalIndex.intersection #26870
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26870 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 180 180
Lines 50716 50716
==========================================
- Hits 46594 46590 -4
- Misses 4122 4126 +4
Continue to review full report at Codecov.
|
pandas/core/indexes/interval.py
Outdated
| @@ -1140,7 +1140,7 @@ def overlaps(self, other): | |||
|
|
|||
| @Appender(_index_shared_docs['intersection']) | |||
| @SetopCheck(op_name='intersection') | |||
| def intersection(self, other, sort=False): | |||
| def intersection(self, other, sort: bool = False): | |||
There was a problem hiding this comment.
can you add typing on other? (and do this for all the intersection calls)?
There was a problem hiding this comment.
I did try something as follows in HEAD~1:
def intersection(self,
other: IntervalIndex,
sort: bool = False
) -> IntervalIndex:
But this will run into the NameError, i.e.,
NameError: name 'IntervalIndex' is not defined
There was a problem hiding this comment.
use the string Intervalndex and this will work
| @@ -1140,7 +1140,10 @@ def overlaps(self, other): | |||
|
|
|||
| @Appender(_index_shared_docs['intersection']) | |||
| @SetopCheck(op_name='intersection') | |||
| def intersection(self, other, sort=False): | |||
| def intersection(self, | |||
There was a problem hiding this comment.
typing nitpick, we use single quotes on these annotations, otherwise lgtm. ping on green.
@WillAyd can we systematically check this?
|
thanks @makbigc |
Follow up #26225 (review)