DOC: Update development documentation urls #26857
Conversation
|
and the README.md? |
Codecov Report
@@ Coverage Diff @@
## master #26857 +/- ##
==========================================
- Coverage 91.88% 41.09% -50.8%
==========================================
Files 179 179
Lines 50696 50696
==========================================
- Hits 46581 20832 -25749
- Misses 4115 29864 +25749
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26857 +/- ##
==========================================
- Coverage 91.86% 91.86% -0.01%
==========================================
Files 180 180
Lines 50712 50712
==========================================
- Hits 46589 46586 -3
- Misses 4123 4126 +3
Continue to review full report at Codecov.
|
|
good point, updated, thanks @simonjayhawkins |
|
how is the domain permissioned? |
|
Not sure what you mean, Wes configured the dns setting, and we set up it in github with a file name |
|
can the prior site redirect to this new one? |
|
Not setting up the dns, I'd say what we could do is replace every html in that site for a page with an http/javascript redirect. I wouldn't bother being the dev site, there shouldn't be important links I guess. But I may be missing something. |
|
discussed with @jorisvandenbossche, and we don't think it's worth bothering on building something to create redirects from the travis dev docs to the new dev docs. If that's all right I'll simply add a note and a link in the home page of the old dev docs, in case anyone is not aware of the change. But we need to merge #26856 first, or travis will overwrite the note. |
|
Agreed it's not worth redirecting.
…On Tue, Jun 18, 2019 at 7:04 AM Marc Garcia ***@***.***> wrote:
discussed with @jorisvandenbossche <https://github.com/jorisvandenbossche>,
and we don't think it's worth bothering on building something to create
redirects from the travis dev docs to the new dev docs.
If that's all right I'll simply add a note and a link in the home page of
the old dev docs, in case anyone is not aware of the change. But we need to
merge #26856 <#26856> first, or
travis will overwrite the note.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#26857?email_source=notifications&email_token=AAKAOIRNKPVP7FBAHT276XTP3DFN5A5CNFSM4HYL3YA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6E6WI#issuecomment-503074649>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIRHYVR566YXAHPGHGDP3DFN5ANCNFSM4HYL3YAQ>
.
|
|
yeah its fine not to redirect (in the docs themselves, but maybe just a message on the site would be fine with the new uri (e.g. a 1-time update) so @datapythonista suggestion seems fine. |
|
Agree, I'll do that once #26856 is merged (we will overwrite the message with the new url from the travis build if we don't stop it first). |
|
I opened https://github.com/pandas-docs/pandas-docs-travis/pull/3 with the redirect message, I don't have write permissions to that repo. Does anyone have them? Otherwise, @jorisvandenbossche I think you've got the github token to push to that repo, don't you? |
|
@jreback does this PR looks good? Probably worth merging soon, since we stopped the travis build now, and the urls are wrong. |
|
thanks @datapythonista |
In #26648 we started building the documentation in https://dev.pandas.io . Updated the links to the development documentation to point to the new url.