Remove annotations to make CI happy #26820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Annotations might just not be possible here given the dynamic nature. Here's a relevant mypy discussion: |
TomAugspurger
approved these changes
Jun 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #26820 +/- ##
==========================================
- Coverage 91.86% 91.86% -0.01%
==========================================
Files 179 179
Lines 50707 50707
==========================================
- Hits 46583 46580 -3
- Misses 4124 4127 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26820 +/- ##
==========================================
- Coverage 91.86% 91.86% -0.01%
==========================================
Files 179 179
Lines 50707 50706 -1
==========================================
- Hits 46583 46579 -4
- Misses 4124 4127 +3
Continue to review full report at Codecov.
|
jreback
approved these changes
Jun 12, 2019
|
lgtm. merge on green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must have been a little quick in merging #26802 as it looks like this is causing mypy failures in CI.
Most of these are pretty niche and I think a result of import machinery. Will try to dive deeper later but this should get things green for now