Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC: Document existing functionality of pandas.DataFrame.to_sql() #11886 #26795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Document existing functionality of pandas.DataFrame.to_sql() #11886 #26795
Changes from 7 commits
12591d1
4397fc7
e9b09c6
d7990f2
47bafad
53a364f
d535914
680ed87
ac44371
52a6782
4cfee29
00d6a25
13633be
82ebc5c
4700af9
9eee1cf
63ed2e3
b03e22f
00a081b
efa97be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry should have asked this before but can you put each parameter on a separate line? Will help with readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also added
Any
tocon=
and added explanation to the note so that less thinking is required later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
dtype
useDict[Any, Dtype]
(Dict from typing, Dtype from pandas._typing)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the
Callable
annotation here. It may be possible to be more precise here. I looked around a bit, finally decided not to write the most complex type annotation in the code base 🤷♂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to match this up with exact types (see the documentation for method)