-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Document existing functionality of pandas.DataFrame.to_sql() #11886 #26795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 20 commits into
pandas-dev:master
from
oguzhanogreden:docs-pr11886
Aug 30, 2019
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
12591d1
DOC: add single dtype to NDFrame.to_sql
oguzhanogreden 4397fc7
Now passes flake8
oguzhanogreden e9b09c6
Update pandas/core/generic.py
oguzhanogreden d7990f2
Update pandas/core/generic.py
oguzhanogreden 47bafad
Type annotations for pandas.core.generic.to_sql()
oguzhanogreden 53a364f
Aligned documentation for pandas.io.sql.to_sql()
oguzhanogreden d535914
Now passes flake8
oguzhanogreden 680ed87
Completed type annotations for generic.NDFrame.to_sql()
oguzhanogreden ac44371
Follow docstring guide for parameter types of pandas.io.sql
oguzhanogreden 52a6782
Avoid circular import
oguzhanogreden 4cfee29
Have one parameter per line
oguzhanogreden 00d6a25
Closes #11415 reported by @martinburch
oguzhanogreden 13633be
Use only _typing.Dtype for dtype=
oguzhanogreden 82ebc5c
Add type checking only imports
oguzhanogreden 4700af9
Merge branch 'master' into docs-pr11886
oguzhanogreden 9eee1cf
merge upstream/master
oguzhanogreden 63ed2e3
Merge branch 'master' into docs-pr11886
oguzhanogreden b03e22f
Clean up merge
oguzhanogreden 00a081b
Remove whitespace
oguzhanogreden efa97be
Fix typo
oguzhanogreden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea this is unfortunate and something we've seen before:
#26029 (comment)
The alias is the suggested approach so no change required here I think, but cc @jreback for visibility