TST/CLN: use float_frame fixture to remove use of tm.getSeriesData() #26787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Clean
Testing
|
Makes sense to me |
Codecov Report
@@ Coverage Diff @@
## master #26787 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 178 178
Lines 50779 50779
==========================================
- Hits 46579 46575 -4
- Misses 4200 4204 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26787 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 178 178
Lines 50779 50779
==========================================
- Hits 46579 46575 -4
- Misses 4200 4204 +4
Continue to review full report at Codecov.
|
|
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes 2 unnecessary fixtures from
pandas\tests\groupby\conftest.pyand a few small changes to remove use of
tm.getSeriesData()with a couple of exceptions:pandas\conftest.pyandpandas\tests\frame\conftest.py(needed for fixtures)pandas\tests\frame\common.py(this module will be removed on completion of TST/CLN: remove TestData from frame-tests; replace with fixtures #22471)pandas\tests\io\json\test_pandas.py(would benefit from fixturisation and access to other frame fixtures, separate PR and then maybe have a code-checks rule forgetSeriesDataintest_*.pyfiles)