Skip to content

DOC: fix old whatsnew examples + few sphinx warnings #26780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2019

Conversation

jorisvandenbossche
Copy link
Member

No description provided.

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone Jun 11, 2019
dtype: object

# same, but specific dtype conversion
In [15]: df3['D'] = df3['D'].astype('float16')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not a big issue since this matches current documentation, but are these types supposed to be exactly the same as the above? Comment suggests so but result does not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they are supposed to be exactly the same. convert_objects did a generic conversion, so using the 64 bit version by default. With astype you could specify a specific type.

Out[2]: MultiIndex(levels=[[1, 2]],
codes=[[0, -2]])

*New Behavior*:

.. ipython:: python

mi1
mi2
mi1 = pd.MultiIndex(levels=[[np.nan, None, pd.NaT, 128, 2]],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't equivalent right? Don't we need to show construction and print separately?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, good catch. Meant to remove the mi1 = as I did above

@jorisvandenbossche
Copy link
Member Author

Checked the log from the travis doc build, now finally looking ok

@jorisvandenbossche jorisvandenbossche merged commit 370054e into pandas-dev:master Jun 11, 2019
@jorisvandenbossche jorisvandenbossche deleted the doc-fixes branch June 11, 2019 15:47
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #26780 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26780      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         178      178              
  Lines       50779    50779              
==========================================
- Hits        46579    46575       -4     
- Misses       4200     4204       +4
Flag Coverage Δ
#multiple 90.31% <ø> (ø) ⬆️
#single 41.18% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.88% <ø> (-0.12%) ⬇️
pandas/core/generic.py 94.1% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea06f8d...a9fe079. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #26780 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26780      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         178      178              
  Lines       50779    50779              
==========================================
- Hits        46579    46575       -4     
- Misses       4200     4204       +4
Flag Coverage Δ
#multiple 90.31% <ø> (ø) ⬆️
#single 41.18% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.88% <ø> (-0.12%) ⬇️
pandas/core/generic.py 94.1% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea06f8d...a9fe079. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants