-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: fix old whatsnew examples + few sphinx warnings #26780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix old whatsnew examples + few sphinx warnings #26780
Conversation
dtype: object | ||
|
||
# same, but specific dtype conversion | ||
In [15]: df3['D'] = df3['D'].astype('float16') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not a big issue since this matches current documentation, but are these types supposed to be exactly the same as the above? Comment suggests so but result does not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they are supposed to be exactly the same. convert_objects
did a generic conversion, so using the 64 bit version by default. With astype you could specify a specific type.
doc/source/whatsnew/v0.25.0.rst
Outdated
Out[2]: MultiIndex(levels=[[1, 2]], | ||
codes=[[0, -2]]) | ||
|
||
*New Behavior*: | ||
|
||
.. ipython:: python | ||
|
||
mi1 | ||
mi2 | ||
mi1 = pd.MultiIndex(levels=[[np.nan, None, pd.NaT, 128, 2]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't equivalent right? Don't we need to show construction and print separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, good catch. Meant to remove the mi1 =
as I did above
Checked the log from the travis doc build, now finally looking ok |
Codecov Report
@@ Coverage Diff @@
## master #26780 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 178 178
Lines 50779 50779
==========================================
- Hits 46579 46575 -4
- Misses 4200 4204 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26780 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 178 178
Lines 50779 50779
==========================================
- Hits 46579 46575 -4
- Misses 4200 4204 +4
Continue to review full report at Codecov.
|
No description provided.