TST/CLN: reuse float_frame fixture in tests\reshape\test_concat.py #26763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Clean
Testing
Codecov Report
@@ Coverage Diff @@
## master #26763 +/- ##
==========================================
- Coverage 91.71% 91.7% -0.01%
==========================================
Files 178 178
Lines 50740 50740
==========================================
- Hits 46538 46533 -5
- Misses 4202 4207 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26763 +/- ##
==========================================
- Coverage 91.71% 91.71% -0.01%
==========================================
Files 178 178
Lines 50740 50740
==========================================
- Hits 46538 46534 -4
- Misses 4202 4206 +4
Continue to review full report at Codecov.
|
jreback
requested changes
Jun 10, 2019
pandas/tests/reshape/test_concat.py
Outdated
| @@ -767,18 +761,18 @@ def test_append(self, sort): | |||
| # append empty | |||
There was a problem hiding this comment.
can you split this tests here (test_append_empty)
pandas/tests/reshape/test_concat.py
Outdated
| assert appended is not self.frame | ||
| appended = empty.append(float_frame) | ||
| tm.assert_frame_equal(float_frame, appended) | ||
| assert appended is not float_frame | ||
|
|
||
| # Overlap |
jreback
approved these changes
Jun 10, 2019
|
lgtm. merge on green. |
|
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.