STYLE: Isort __init__ files #26749
STYLE: Isort __init__ files #26749
Conversation
alimcmaster1
commented
Jun 9, 2019
alimcmaster1
commented
- related to Fix import formatting using isort #23334
- passes git diff upstream/master -u -- "*.py" | flake8 --diff
pandas/core/internals/__init__.py
Outdated
| BlockManager, SingleBlockManager, create_block_manager_from_arrays, | ||
| create_block_manager_from_blocks) | ||
| from .managers import \ | ||
| concatenate_block_managers # noqa:F401; reshape.concat, reshape.merge |
There was a problem hiding this comment.
why do you have these separated? don't use \ for conuation, use parens
| concatenate_block_managers # noqa:F401; reshape.concat, reshape.merge | ||
| from .managers import items_overlap_with_suffix # reshape.merge | ||
|
|
||
| from .blocks import _block_shape # noqa:F401; io.pytables |
There was a problem hiding this comment.
why would this be after the others? (and why don't you have .blocks all in one)
setup.cfg
Outdated
| pandas/_libs/tslibs/__init__.py | ||
| pandas/util/__init__.py | ||
| pandas/arrays/__init__.py | ||
| pandas/io/msgpack/__init__.py |
Codecov Report
@@ Coverage Diff @@
## master #26749 +/- ##
==========================================
- Coverage 91.7% 91.69% -0.01%
==========================================
Files 179 179
Lines 50767 50776 +9
==========================================
+ Hits 46555 46560 +5
- Misses 4212 4216 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26749 +/- ##
==========================================
- Coverage 92.05% 91.71% -0.35%
==========================================
Files 180 178 -2
Lines 50726 50775 +49
==========================================
- Hits 46696 46568 -128
- Misses 4030 4207 +177
Continue to review full report at Codecov.
|
|
Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-28 12:31:59 UTC |
|
there are still 3 non-trivial isorts that remain (aside from the asv ones); but these I think require updating the setup.cfg for isort itself to ensure our ordering to avoid circular imports; alternatively we can put some isort ignores in the file (specifically pandas/init.py) |
|
Thanks for fixing this up @jreback it was on my to do list I promise! |
