Skip to content

DEPS: Adding missing doc dependencies to environment.yml #26657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019
Merged

DEPS: Adding missing doc dependencies to environment.yml #26657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,17 @@ dependencies:
- flake8-rst>=0.6.0,<=0.7.0
- gitpython
- hypothesis>=3.82
- ipywidgets
- isort
- moto
- mypy
- nbconvert>=5.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put some comments and/or group dependencies in this file as much as possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, didn't think about additional grouping which makes sense, but was thinking on a comment for each dependency to explain where/why is needed. Otherwise will be difficult to know when any can be removed.

May be in a separate PR, since all them need it, and it's unrelated to the changes here? I'll create an issue, we have a sprint tonight where surely someone can work on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that's fine; I think grouping with a single comment is prob good enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #26659

- nbformat
- notebook>=5.7.5
- pandoc
- pycodestyle
- pyqt
- python-snappy
- pytest>=4.0.2
- pytest-mock
- sphinx
Expand Down
7 changes: 7 additions & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,17 @@ flake8-comprehensions
flake8-rst>=0.6.0,<=0.7.0
gitpython
hypothesis>=3.82
ipywidgets
isort
moto
mypy
nbconvert>=5.4.1
nbformat
notebook>=5.7.5
pandoc
pycodestyle
pyqt
python-snappy
pytest>=4.0.2
pytest-mock
sphinx
Expand Down