Skip to content

ENH: Support multiple opening hours intervals for BusinessHour #26628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 28, 2019
Merged

ENH: Support multiple opening hours intervals for BusinessHour #26628

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ecfc92e
Fix BusinessHour docstring
May 15, 2019
63f0b52
Support multiple starting and ending times in BusinessHour
May 14, 2019
4cd7db1
Edit comments and tests
May 20, 2019
170d08b
Edit error messages
May 20, 2019
e39a688
Update tests
Jun 7, 2019
097a0fa
Add test
howsiwei Jun 8, 2019
1478845
Update code and comments
Jun 11, 2019
2669ee4
Merge remote-tracking branch 'upstream/master' into businesshour
Jun 11, 2019
7575597
Fix lint errors
Jun 11, 2019
6b72cea
Fix mypy errors
howsiwei Jun 11, 2019
90fa744
Remove type signatures as they don't play well with python 3.5
howsiwei Jun 26, 2019
13fb339
Merge branch 'master' into businesshour
howsiwei Jun 26, 2019
6179197
Make minor changes
howsiwei Jun 28, 2019
71f82c3
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
howsiwei Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Other Enhancements
- :meth:`DataFrame.query` and :meth:`DataFrame.eval` now supports quoting column names with backticks to refer to names with spaces (:issue:`6508`)
- :func:`merge_asof` now gives a more clear error message when merge keys are categoricals that are not equal (:issue:`26136`)
- :meth:`pandas.core.window.Rolling` supports exponential (or Poisson) window type (:issue:`21303`)
-
- :class: `pandas.offsets.BusinessHour` supports multiple opening hours intervals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space between :class: and pandas.offsets.BusinessHour. Also can you include the issue number this PR closes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


.. _whatsnew_0250.api_breaking:

Expand Down
Loading