-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC/CI: restore travis CI doc build environment #26621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/CI: restore travis CI doc build environment #26621
Conversation
Although I suppose it is actually the intent of |
Codecov Report
@@ Coverage Diff @@
## master #26621 +/- ##
==========================================
- Coverage 91.86% 91.85% -0.01%
==========================================
Files 174 174
Lines 50722 50722
==========================================
- Hits 46594 46589 -5
- Misses 4128 4133 +5
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26621 +/- ##
==========================================
- Coverage 91.86% 91.85% -0.01%
==========================================
Files 174 174
Lines 50722 50722
==========================================
- Hits 46594 46589 -5
- Misses 4128 4133 +5
Continue to review full report at Codecov.
|
@jorisvandenbossche looks fine, merge away when ready |
I guess I'm missing something. I think I added to For me it makes much more sense than when we build the documentation locally, we use the same environment as when it's built in travis, I don't see why we would like to have different / less packages, or different versions. If we do what you suggest, upgrading python to 3.7 only for the docs, but not for local environemnts, or similar things, we'll find that we start working on the docs (let's say fixing the warnings), we get something working locally, and then when we upload the changes the docs can fail. I don't see the advantage. If But feel free to merge if you disagree, not a big deal. |
Well, just look at the log output, and you will see that there is something missing in the environment / some things not working in the doc build. I am fine with unifying the environments, I won't object that (the environment.yml is already huge anyhow .. so that ship has sailed). But let's try to do that again in a proper way in a new PR. So going to merge this, just to have our doc build working again (we already introduced some new errors in recent PRs, which was not visible any more). |
Thanks for fixing those. I agree on what you say, and it was my bad for not detecting the failure myself. I was planning to check the new docs built, but azure-pipelines started to fail randomly, and the priority was to restore building master, and I didn't time to look much at the travis changes in the logs. My point was that the docs should build with |
xref #26591 (comment)
This is one option (adding back the specific doc build environment yml file), another option would be to actually update the main
environment.yaml
file to be suitable for the doc build.At the moment, my preference is to add back the separate yml file because 1) those additional dependencies are not necessarily needed for a dev env setup, and just makes that env even more heavy and 2) we might want to pin to certain versions from time to time for the doc build (eg we should consider pinning sphinx to < 2.0, which is not necessarily needed for all contributors to do as well).
Another thing is that this env could actually use an update (eg python 3.6 -> 3.7)
cc @datapythonista