Skip to content

[CI] Add pytest-azurepipelines in ​pandas-dev #26620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 28, 2019

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented Jun 2, 2019

Is it better to put pip install pytest-azurepipelines inside setup_env.sh?

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #26620 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26620      +/-   ##
==========================================
- Coverage   91.85%   91.85%   -0.01%     
==========================================
  Files         174      174              
  Lines       50722    50722              
==========================================
- Hits        46593    46589       -4     
- Misses       4129     4133       +4
Flag Coverage Δ
#multiple 90.39% <ø> (ø) ⬆️
#single 41.78% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437efa6...61a5f9d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #26620 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26620      +/-   ##
==========================================
- Coverage    91.7%   91.69%   -0.01%     
==========================================
  Files         179      179              
  Lines       50767    50767              
==========================================
- Hits        46555    46551       -4     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.29% <ø> (ø) ⬆️
#single 41.2% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7748ca...3bf5b9b. Read the comment docs.

@simonjayhawkins simonjayhawkins added Build Library building on various platforms CI Continuous Integration labels Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

you can try adding this to setup_env.sh.

I think this doesn't work this way because the commandas are executed in different shells (so another option is to do it in the same context

activate pandas-dev && pip instal .....

@makbigc makbigc changed the title [CI] Add pytest-azurepipelines in posix.yml and windows.yml [CI] Add pytest-azurepipelines in ​pandas-dev Jun 3, 2019
@makbigc
Copy link
Contributor Author

makbigc commented Jun 5, 2019

@jreback Do you have anything else to implement?

@@ -28,3 +28,4 @@ dependencies:
# for python 3.5, pytest>=4.0.2 is not available in conda
- pytest==4.5.0
- html5lib==1.0b2
- pytest-azurepipelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be installed from conda-forge?

@makbigc
Copy link
Contributor Author

makbigc commented Jun 10, 2019

@TomAugspurger Implemented. Anything else?

@TomAugspurger
Copy link
Contributor

The pytest-azurepiplines docs state that it

Overloads the –junit-xml flag on execution with a default value

Will this break our coverage output for codecov?

@makbigc
Copy link
Contributor Author

makbigc commented Jun 10, 2019

I guess no break is done. Codecov report was also generated in this PR. Is it sufficient? Would you tell me any other way to prove?

@jreback jreback mentioned this pull request Jun 27, 2019
4 tasks
@jreback jreback added this to the 0.25.0 milestone Jun 28, 2019
@jreback jreback merged commit 45ea267 into pandas-dev:master Jun 28, 2019
@jreback
Copy link
Contributor

jreback commented Jun 28, 2019

thanks @makbigc

cc @pandas-dev/pandas-core we now have a warnings tab in summary: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=13516&view=results

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Use azure-pipelines reporting for pytest data
4 participants