Skip to content

CI: pin pytest version on Python 3.5 #26619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2019
Merged

CI: pin pytest version on Python 3.5 #26619

merged 3 commits into from
Jun 2, 2019

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jun 2, 2019 •
edited
Loading

closes #26614

@simonjayhawkins simonjayhawkins added CI Continuous Integration Dependencies Required and optional dependencies Python 3.5 labels Jun 2, 2019
@simonjayhawkins simonjayhawkins added this to the 0.25.0 milestone Jun 2, 2019
jreback
jreback reviewed Jun 2, 2019
View reviewed changes
ci/deps/azure-35-compat.yaml Outdated
@@ -26,5 +26,5 @@ dependencies:
- pip
- pip:
# for python 3.5, pytest>=4.0.2 is not available in conda
- pytest>=4.0.2
- pytest>=4.0.2,!=4.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see what they used on the last good build and pin to that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.5.0

@simonjayhawkins simonjayhawkins changed the title CI: dependencies for pytest and Python 3.5 CI: pin pytest version on Python 3.5 Jun 2, 2019
@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #26619 into master will decrease coverage by 50.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26619       +/-   ##
===========================================
- Coverage   91.85%   41.78%   -50.08%     
===========================================
  Files         174      174               
  Lines       50722    50722               
===========================================
- Hits        46593    21193    -25400     
- Misses       4129    29529    +25400
Flag Coverage Δ
#multiple ?
#single 41.78% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.14% <0%> (-89.86%) ⬇️
pandas/io/s3.py 0% <0%> (-89.48%) ⬇️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437efa6...e2d838e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 2, 2019 •
edited
Loading

Codecov Report

Merging #26619 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26619      +/-   ##
==========================================
- Coverage   91.85%   91.85%   -0.01%     
==========================================
  Files         174      174              
  Lines       50722    50722              
==========================================
- Hits        46593    46589       -4     
- Misses       4129     4133       +4
Flag Coverage Δ
#multiple 90.39% <ø> (ø) ⬆️
#single 41.78% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437efa6...e2d838e. Read the comment docs.

@jreback jreback merged commit addc5fc into pandas-dev:master Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

thanks @simonjayhawkins

@alimcmaster1 alimcmaster1 mentioned this pull request Jun 3, 2019
Closed
@simonjayhawkins simonjayhawkins deleted the fix-py35 branch June 3, 2019 11:15
vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019
@simonjayhawkins @vaibhavhrt
CI: pin pytest version on Python 3.5 (pandas-dev#26619)
1f83733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

CI failing - All builds are failing on python 3.5 on pytest 4.6
2 participants
@simonjayhawkins @jreback