Skip to content

TST/CLN: deduplicate fixture from test_to_latex.py #26603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

simonjayhawkins
Copy link
Member

this PR is basically just to promote the float_frame fixture to top-level conftest.

once there, there is opportunities to re-use by fixturising current instances of

df = DataFrame(tm.getSeriesData())

also allows removing duplicate fixture from pandas/tests/io/formats/test_to_latex.py

so this is just a move for now, fixturization in follow-on PRs

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 1, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 1, 2019
@jreback
Copy link
Contributor

jreback commented Jun 1, 2019

lgtm. CI failing on doc build, so will merge after that is disabled.

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@437efa6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26603   +/-   ##
=========================================
  Coverage          ?   91.84%           
=========================================
  Files             ?      174           
  Lines             ?    50707           
  Branches          ?        0           
=========================================
  Hits              ?    46574           
  Misses            ?     4133           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.38% <ø> (?)
#single 41.76% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437efa6...3b3c0f0. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 1, 2019

i think i accidentally cancellled this one
can u merge master and ping on green

@simonjayhawkins
Copy link
Member Author

@jreback all green

@WillAyd WillAyd merged commit 5c6dd43 into pandas-dev:master Jun 2, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 2, 2019

Thanks @simonjayhawkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants