Add more specific error message when user passes incorrect matrix format to from_coo #26584

fhoang7 · 2019-05-31T01:31:58Z

closes ERR: give better error message when providing wrong sparse matrix type in from_coo #26554
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

…e non regression tests

pandas/core/arrays/sparse.py

codecov · 2019-05-31T02:09:49Z

Codecov Report

Merging #26584 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26584      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.01%     
==========================================
  Files         174      174              
  Lines       50644    50647       +3     
==========================================
- Hits        46516    46514       -2     
- Misses       4128     4133       +5

Flag	Coverage Δ
#multiple	`90.37% <100%> (ø)`	⬆️
#single	`41.69% <0%> (-0.11%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/sparse.py	`93.09% <100%> (+0.02%)`	⬆️
pandas/io/gbq.py	`78.94% <0%> (-10.53%)`	⬇️
pandas/core/frame.py	`97% <0%> (-0.12%)`	⬇️
pandas/util/testing.py	`90.81% <0%> (-0.11%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c54dd2...811647d. Read the comment docs.

codecov · 2019-05-31T02:09:49Z

Codecov Report

Merging #26584 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26584      +/-   ##
==========================================
- Coverage   91.86%   91.85%   -0.01%     
==========================================
  Files         174      174              
  Lines       50722    50725       +3     
==========================================
- Hits        46594    46593       -1     
- Misses       4128     4132       +4

Flag	Coverage Δ
#multiple	`90.39% <100%> (ø)`	⬆️
#single	`41.79% <0%> (-0.09%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/sparse/scipy_sparse.py	`100% <100%> (ø)`	⬆️
pandas/io/gbq.py	`78.94% <0%> (-10.53%)`	⬇️
pandas/core/frame.py	`97% <0%> (-0.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addc5fc...cc44ac0. Read the comment docs.

doc/source/whatsnew/v0.25.0.rst

pandas/core/arrays/sparse.py

pandas/tests/arrays/sparse/test_array.py

Move try-catch block to _coo_to_sparse_series Update entry log

pep8speaks · 2019-05-31T22:25:41Z

Hello @fhoang7! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-02 15:07:35 UTC

fhoang7 · 2019-06-01T13:11:39Z

@TomAugspurger @jreback: Changes made! Please review when you get the chance. Thanks!

doc/source/whatsnew/v0.25.0.rst

pandas/core/sparse/scipy_sparse.py

pandas/tests/arrays/sparse/test_accessor.py

- Simplify scope of except Block - comment on non-regression test

fhoang7 · 2019-06-01T14:34:12Z

@jreback: Thanks for the feedback! Changes are pushed.

jreback

thank @fhoang7 looks pretty good. you will want to wait a little to merge master as turning off a doc validation check in the CI (which is causing this to fail); though there are some small issues as indicated.

pandas/core/sparse/scipy_sparse.py

pandas/tests/arrays/sparse/test_accessor.py

doc/source/whatsnew/v0.25.0.rst

- Move comment inside test - Update docstring delineator bar

fhoang7 · 2019-06-01T17:38:41Z

Done! @jreback

pandas/tests/arrays/sparse/test_accessor.py

… in functionality

fhoang7 · 2019-06-01T22:45:53Z

@simonjayhawkins: Made requested changes. Thanks for your feedback!

doc/source/whatsnew/v0.25.0.rst

pandas/tests/arrays/sparse/test_accessor.py

fhoang7 · 2019-06-01T23:56:38Z

@simonjayhawkins: Pushed suggested changes.

simonjayhawkins · 2019-06-02T00:08:00Z

lgtm. not sure if you saw the comments on the error mesage check and the test name. if you can address those i think we're done

fhoang7 · 2019-06-02T00:23:16Z

@simonjayhawkins: Yup latest commit reflect those changes. Only thing is not sure why some checks are fixing so I only changed comments/test name. Looks like similar errors in the past builds before me.

simonjayhawkins · 2019-06-02T00:35:43Z

Only thing is not sure why some checks are fixing so I only changed comments/test name. Looks like similar errors in the past builds before me.

failing CI is not related to your changes

Yup latest commit reflect those changes

please address #26584 (comment) and #26584 (comment)

fhoang7 · 2019-06-02T00:50:36Z

@simonjayhawkins: Thanks for your patience and input. Addressed those comments and double checked over your previous comments as well to make sure I resolved them.

simonjayhawkins

thanks @fhoang7 approved assuming green on py3.5 @TomAugspurger @jreback

simonjayhawkins

@fhoang7 failing CI is now fixed. can you merge master.

fhoang7 · 2019-06-02T15:08:03Z

@simonjayhawkins: Thanks for the headsup. Merged/pushed up.

jreback · 2019-06-02T23:43:03Z

thanks @fhoang7

…mat to from_coo (pandas-dev#26584)

fhoang7 added 2 commits May 30, 2019 20:18

Include more specific error messaging for non coo matrix and introduc…

ed8baec

…e non regression tests

Log changes to what's new

811647d

simonjayhawkins added Error Reporting Incorrect or improved errors from pandas Sparse Sparse Data Type labels May 31, 2019

jreback requested changes May 31, 2019

View reviewed changes

pandas/core/arrays/sparse.py Outdated Show resolved Hide resolved

TomAugspurger reviewed May 31, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

pandas/core/arrays/sparse.py Outdated Show resolved Hide resolved

pandas/tests/arrays/sparse/test_array.py Outdated Show resolved Hide resolved

Remove redundant test

282bc9f

Move try-catch block to _coo_to_sparse_series Update entry log

fhoang7 added 5 commits May 31, 2019 17:27

Fix pep8

ceab97d

Change test to expect TypeError

69ea6f2

Update what's new

21ecdab

Update docstring to reflect what will be returned in an error state

d8405fc

Merge remote-tracking branch 'upstream/master' into first-feature

18a62b9

jreback requested changes Jun 1, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

pandas/core/sparse/scipy_sparse.py Show resolved Hide resolved

pandas/core/sparse/scipy_sparse.py Outdated Show resolved Hide resolved

pandas/tests/arrays/sparse/test_accessor.py Show resolved Hide resolved

- Update what's new

b2b9239

- Simplify scope of except Block - comment on non-regression test

jreback requested changes Jun 1, 2019

View reviewed changes

pandas/core/sparse/scipy_sparse.py Outdated Show resolved Hide resolved

pandas/tests/arrays/sparse/test_accessor.py Outdated Show resolved Hide resolved

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

jreback added this to the 0.25.0 milestone Jun 1, 2019

- Clean up what's new formatting

fb6e0d9

- Move comment inside test - Update docstring delineator bar

simonjayhawkins reviewed Jun 1, 2019

View reviewed changes

pandas/tests/arrays/sparse/test_accessor.py Outdated Show resolved Hide resolved

simonjayhawkins reviewed Jun 1, 2019

View reviewed changes

pandas/tests/arrays/sparse/test_accessor.py Outdated Show resolved Hide resolved

Add message assertion to test and change test name to be more verbose…

8739f29

… in functionality

simonjayhawkins reviewed Jun 1, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

simonjayhawkins reviewed Jun 1, 2019

View reviewed changes

pandas/tests/arrays/sparse/test_accessor.py Outdated Show resolved Hide resolved

Proper formatting in what's new + proper commenting for test

633b1ff

Fix test name for consistency and assert on literal message

206faff

simonjayhawkins approved these changes Jun 2, 2019

View reviewed changes

simonjayhawkins requested changes Jun 2, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into first-feature

cc44ac0

simonjayhawkins approved these changes Jun 2, 2019

View reviewed changes

jreback approved these changes Jun 2, 2019

View reviewed changes

jreback merged commit 6354580 into pandas-dev:master Jun 2, 2019

vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019

Add more specific error message when user passes incorrect matrix for…

c95be62

…mat to from_coo (pandas-dev#26584)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more specific error message when user passes incorrect matrix format to from_coo #26584

Add more specific error message when user passes incorrect matrix format to from_coo #26584

fhoang7 commented May 31, 2019 •

edited

Loading

codecov bot commented May 31, 2019

codecov bot commented May 31, 2019 •

edited

Loading

pep8speaks commented May 31, 2019 •

edited

Loading

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

jreback left a comment

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

simonjayhawkins commented Jun 2, 2019

fhoang7 commented Jun 2, 2019 •

edited

Loading

simonjayhawkins commented Jun 2, 2019

fhoang7 commented Jun 2, 2019

simonjayhawkins left a comment

simonjayhawkins left a comment

fhoang7 commented Jun 2, 2019

jreback commented Jun 2, 2019

Add more specific error message when user passes incorrect matrix format to from_coo #26584

Add more specific error message when user passes incorrect matrix format to from_coo #26584

Conversation

fhoang7 commented May 31, 2019 • edited Loading

codecov bot commented May 31, 2019

Codecov Report

codecov bot commented May 31, 2019 • edited Loading

Codecov Report

pep8speaks commented May 31, 2019 • edited Loading

Comment last updated at 2019-06-02 15:07:35 UTC

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

jreback left a comment

Choose a reason for hiding this comment

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

fhoang7 commented Jun 1, 2019

simonjayhawkins commented Jun 2, 2019

fhoang7 commented Jun 2, 2019 • edited Loading

simonjayhawkins commented Jun 2, 2019

fhoang7 commented Jun 2, 2019

simonjayhawkins left a comment

Choose a reason for hiding this comment

simonjayhawkins left a comment

Choose a reason for hiding this comment

fhoang7 commented Jun 2, 2019

jreback commented Jun 2, 2019

fhoang7 commented May 31, 2019 •

edited

Loading

codecov bot commented May 31, 2019 •

edited

Loading

pep8speaks commented May 31, 2019 •

edited

Loading

fhoang7 commented Jun 2, 2019 •

edited

Loading