Skip to content

BUG: Fix RecursionError when using a scalar point to select IntervalIndex columns #26570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jschendel
Copy link
Member

@jschendel jschendel added Bug Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type labels May 30, 2019
@jschendel jschendel added this to the 0.25.0 milestone May 30, 2019
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #26570 into master will decrease coverage by 50.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26570       +/-   ##
===========================================
- Coverage   91.77%   41.68%   -50.09%     
===========================================
  Files         174      174               
  Lines       50681    50681               
===========================================
- Hits        46513    21127    -25386     
- Misses       4168    29554    +25386
Flag Coverage Δ
#multiple ?
#single 41.68% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 34.99% <0%> (-62.13%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.14% <0%> (-89.86%) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8154efb...4e3f242. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #26570 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26570      +/-   ##
==========================================
- Coverage   91.77%   91.76%   -0.01%     
==========================================
  Files         174      174              
  Lines       50681    50683       +2     
==========================================
- Hits        46513    46511       -2     
- Misses       4168     4172       +4
Flag Coverage Δ
#multiple 90.3% <100%> (ø) ⬆️
#single 41.66% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97% <100%> (-0.12%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8154efb...4e3f242. Read the comment docs.

indexer = self.columns.get_loc(key)
if isinstance(self.columns, ABCIntervalIndex):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather would not inject specific index logic here

you can make this not a single key (so it takes a different branch)

or define one of the _convert_to_index routines which dispatch to the index type

@jreback
Copy link
Contributor

jreback commented Jun 27, 2019

@jschendel can you merge master and had some comments

@jreback jreback removed this from the 0.25.0 milestone Jun 28, 2019
@jbrockmendel
Copy link
Member

@jschendel can you rebase

@jschendel
Copy link
Member Author

I don't have a cleaner implementation here, and will need to come back to this later. Closing for now as I don't want this sitting around stale.

@jschendel jschendel closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecursionError when selecting single column from IntervalIndex
3 participants