-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix RecursionError when using a scalar point to select IntervalIndex columns #26570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26570 +/- ##
===========================================
- Coverage 91.77% 41.68% -50.09%
===========================================
Files 174 174
Lines 50681 50681
===========================================
- Hits 46513 21127 -25386
- Misses 4168 29554 +25386
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26570 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 174 174
Lines 50681 50683 +2
==========================================
- Hits 46513 46511 -2
- Misses 4168 4172 +4
Continue to review full report at Codecov.
|
indexer = self.columns.get_loc(key) | ||
if isinstance(self.columns, ABCIntervalIndex): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather would not inject specific index logic here
you can make this not a single key (so it takes a different branch)
or define one of the _convert_to_index routines which dispatch to the index type
@jschendel can you merge master and had some comments |
@jschendel can you rebase |
I don't have a cleaner implementation here, and will need to come back to this later. Closing for now as I don't want this sitting around stale. |
git diff upstream/master -u -- "*.py" | flake8 --diff