Skip to content

Provide ExtensionDtype.construct_from_string by default #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 6, 2019
Merged

Provide ExtensionDtype.construct_from_string by default #26562

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
20ec4e4
Provide Extension.Dtype.construct_from_string by default
datapythonista May 29, 2019
abb5eb1
Merge remote-tracking branch 'upstream/master' into construct_from_st…
datapythonista May 29, 2019
661d522
Improving construct_from_string docstring, and remove unnecessary ove…
datapythonista May 29, 2019
8ff1965
Ignoring flake8 false positive
datapythonista May 29, 2019
609910c
Merge remote-tracking branch 'upstream/master' into construct_from_st…
May 30, 2019
a50301a
Addressing CI and PR comments: implementing tests, fixing docstring e…
May 30, 2019
e04ed79
Adding type annotations
May 30, 2019
ef2d005
Merge remote-tracking branch 'upstream/master' into construct_from_st…
May 31, 2019
54cca4f
Merge remote-tracking branch 'upstream/master' into construct_from_st…
Jun 5, 2019
7fa61d2
Moving tests to pandas/tests/extension/
Jun 5, 2019
2897ad2
Fixing test (error message)
Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/dtypes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,10 @@ def construct_from_string(cls, string):
... raise TypeError("Cannot construct a '{}' from "
... "'{}'".format(cls, string))
"""
raise AbstractMethodError(cls)
if string != cls.name:
raise TypeError("Cannot construct a '{}' from '{}'".format(
cls.__name__, string))
return cls()

@classmethod
def is_dtype(cls, dtype):
Expand Down