Skip to content

DOC: fix broken link for .iloc #26533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #26533 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26533      +/-   ##
==========================================
- Coverage   91.76%   91.76%   -0.01%     
==========================================
  Files         174      174              
  Lines       50629    50629              
==========================================
- Hits        46462    46458       -4     
- Misses       4167     4171       +4
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.68% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexing.py 90.53% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a516c1...065c299. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #26533 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26533      +/-   ##
==========================================
- Coverage   91.76%   91.76%   -0.01%     
==========================================
  Files         174      174              
  Lines       50629    50629              
==========================================
- Hits        46462    46458       -4     
- Misses       4167     4171       +4
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.68% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexing.py 90.53% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a516c1...065c299. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented May 26, 2019

Looks good. Was this causing any warnings during the build?

@simonjayhawkins
Copy link
Member Author

Lots of warnings on the Travis doc build but no match for iloc.

i noticed this error while reading the Series.iloc docs. (as an aside, the See Also refers to Series.iloc which only makes sense for DataFrame.iloc but they share the same docstring)

did a quick grep for similar ref issues on the codebase, nothing found.

@WillAyd WillAyd added this to the 0.25.0 milestone May 27, 2019
@jreback
Copy link
Contributor

jreback commented May 27, 2019

lgtm. @simonjayhawkins merge away.

@simonjayhawkins simonjayhawkins merged commit 947126d into pandas-dev:master May 27, 2019
@simonjayhawkins simonjayhawkins deleted the broken_link_iloc branch May 27, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants