-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Add defensive check for argument errors keyword in to_numeric #26466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sumanau7 : Thanks for the PR! Can you add a test and a |
@gfyoung sure i will complete it within next 24 hours and update. |
Codecov Report
@@ Coverage Diff @@
## master #26466 +/- ##
==========================================
- Coverage 91.74% 91.74% -0.01%
==========================================
Files 174 174
Lines 50763 50765 +2
==========================================
- Hits 46575 46574 -1
- Misses 4188 4191 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26466 +/- ##
==========================================
- Coverage 91.74% 91.74% -0.01%
==========================================
Files 174 174
Lines 50763 50765 +2
==========================================
- Hits 46575 46573 -2
- Misses 4188 4192 +4
Continue to review full report at Codecov.
|
@gfyoung Is it good now ? |
errors
in func to_numeric
.
@sumanau7 thanks a lot! |
git diff upstream/master -u -- "*.py" | flake8 --diff
errors
in functo_numeric