Skip to content

Add defensive check for argument errors keyword in to_numeric #26466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2019

Conversation

sumanau7
Copy link
Contributor

@sumanau7 sumanau7 commented May 20, 2019

@gfyoung gfyoung added Error Reporting Incorrect or improved errors from pandas Numeric Operations Arithmetic, Comparison, and Logical operations labels May 20, 2019
@gfyoung
Copy link
Member

gfyoung commented May 20, 2019

@sumanau7 : Thanks for the PR! Can you add a test and a whatsnew entry into v0.25.0.rst?

@sumanau7
Copy link
Contributor Author

@gfyoung sure i will complete it within next 24 hours and update.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #26466 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26466      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50763    50765       +2     
==========================================
- Hits        46575    46574       -1     
- Misses       4188     4191       +3
Flag Coverage Δ
#multiple 90.25% <100%> (ø) ⬆️
#single 41.69% <0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/numeric.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5498...4de3f1a. Read the comment docs.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #26466 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26466      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50763    50765       +2     
==========================================
- Hits        46575    46573       -2     
- Misses       4188     4192       +4
Flag Coverage Δ
#multiple 90.25% <50%> (-0.01%) ⬇️
#single 41.72% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/numeric.py 98.55% <50%> (-1.45%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5498...5bdd8a4. Read the comment docs.

@sumanau7
Copy link
Contributor Author

@gfyoung Is it good now ?

@jorisvandenbossche jorisvandenbossche changed the title Add defensive check for argument errors in func to_numeric. Add defensive check for argument errors keyword in to_numeric May 20, 2019
@jorisvandenbossche jorisvandenbossche merged commit 1add02c into pandas-dev:master May 20, 2019
@jorisvandenbossche
Copy link
Member

@sumanau7 thanks a lot!

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone May 20, 2019
gfyoung added a commit that referenced this pull request May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_numeric does not validate the errors keyword
3 participants