Skip to content

Fix 'observed' kwarg not doing anything on SeriesGroupBy #26461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

krsnik93
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented May 19, 2019

Hello @krsnik93! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-19 21:28:27 UTC

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a simpler way of going about this. Does adding _reindex_output to _wrap_output in SeriesGroupBy fix it instead? I think the problem might just be that the DataFrameGroupBy wrap methods have that already but the SeriesGroupBy ones don't, so that could help

@krsnik93 krsnik93 closed this May 19, 2019
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #26461 into master will decrease coverage by 50.05%.
The diff coverage is 12.9%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26461       +/-   ##
===========================================
- Coverage   91.74%   41.69%   -50.06%     
===========================================
  Files         174      174               
  Lines       50748    50751        +3     
===========================================
- Hits        46560    21161    -25399     
- Misses       4188    29590    +25402
Flag Coverage Δ
#multiple ?
#single 41.69% <12.9%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 13% <12.5%> (-75.96%) ⬇️
pandas/core/groupby/groupby.py 23.94% <13.04%> (-73.3%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99e84f...2575c41. Read the comment docs.

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #26461 into master will decrease coverage by <.01%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26461      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50748    50751       +3     
==========================================
  Hits        46560    46560              
- Misses       4188     4191       +3
Flag Coverage Δ
#multiple 90.25% <96.77%> (ø) ⬆️
#single 41.71% <12.9%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 88.81% <100%> (-0.16%) ⬇️
pandas/core/groupby/groupby.py 97.18% <95.65%> (-0.06%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99e84f...2575c41. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented May 19, 2019

@krsnik93 this PR might be ok

@jreback jreback reopened this May 19, 2019
@krsnik93 krsnik93 closed this May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observed keyword for SeriesGroupBy Ignored
4 participants