-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix 'observed' kwarg not doing anything on SeriesGroupBy #26461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a simpler way of going about this. Does adding _reindex_output
to _wrap_output
in SeriesGroupBy fix it instead? I think the problem might just be that the DataFrameGroupBy wrap methods have that already but the SeriesGroupBy ones don't, so that could help
Codecov Report
@@ Coverage Diff @@
## master #26461 +/- ##
===========================================
- Coverage 91.74% 41.69% -50.06%
===========================================
Files 174 174
Lines 50748 50751 +3
===========================================
- Hits 46560 21161 -25399
- Misses 4188 29590 +25402
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26461 +/- ##
==========================================
- Coverage 91.74% 91.74% -0.01%
==========================================
Files 174 174
Lines 50748 50751 +3
==========================================
Hits 46560 46560
- Misses 4188 4191 +3
Continue to review full report at Codecov.
|
@krsnik93 this PR might be ok |
observed
keyword for SeriesGroupBy Ignored #24880git diff upstream/master -u -- "*.py" | flake8 --diff