WIP: Add indent support in to_json #26457
Conversation
WillAyd
changed the title
| @@ -981,13 +996,17 @@ void encode(JSOBJ obj, JSONObjectEncoder *enc, const char *name, | |||
| enc->iterBegin(obj, &tc); | |||
|
|
|||
| Buffer_AppendCharUnchecked(enc, '{'); | |||
| Buffer_AppendIndentNewlineUnchecked (enc); | |||
| Buffer_AppendIndentUnchecked (enc, enc->level + 2); | |||
There was a problem hiding this comment.
As mentioned this + 2 isn't permanent just a hack during WIP to get this to work. Something seems off with the level struct member I just haven't figured out yet
Codecov Report
@@ Coverage Diff @@
## master #26457 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 174 174
Lines 50754 50755 +1
==========================================
- Hits 46560 46557 -3
- Misses 4194 4198 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26457 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 174 174
Lines 50754 50755 +1
==========================================
- Hits 46560 46557 -3
- Misses 4194 4198 +4
Continue to review full report at Codecov.
|
|
Meant to open this as a draft PR - going to close to get it out of the queue but do plan on picking back up in the near term |
to_jsonmethod #12004git diff upstream/master -u -- "*.py" | flake8 --diffThis is a WIP and requires a little more refinement (namely around how
levelis incremented in the extension module, testing arrays) but is more or less the direction I think we could head inThis is mostly inspired by changes done in ultrajson/ultrajson@930dfa5#diff-edae06c872e58ad6edf574f4414aac9f