-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: ecosystem.rst: Koalas #26425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: ecosystem.rst: Koalas #26425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26425 +/- ##
==========================================
- Coverage 91.69% 91.69% -0.01%
==========================================
Files 174 174
Lines 50741 50741
==========================================
- Hits 46529 46525 -4
- Misses 4212 4216 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26425 +/- ##
==========================================
- Coverage 91.69% 91.69% -0.01%
==========================================
Files 174 174
Lines 50741 50741
==========================================
- Hits 46529 46525 -4
- Misses 4212 4216 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26425 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 174 174
Lines 50741 50741
==========================================
- Hits 46548 46544 -4
- Misses 4193 4197 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you took the description from Koalas documentation, but it sounds more like a sales speech than a useful description (e.g. be more productive when interacting with big data
).
Also, I think we can safely assume that users checking this documentation know what pandas is (and probably spark).
Can you please rephrases, being concise on what Koalas does. Also, didn't check Koalas, but I doubt it implements the full pandas API with spark as a backend. Please add what users can expect in terms of stability and completeness of the API.
Sure, will do. Thanks! |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Koalas provides a familiar pandas DataFrame interface on top of Apache Spark. It enables users to leverage multi-cores on one machine or a cluster of machines to speed up or scale their DataFrame code. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datapythonista, how does it looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is much better in my opinion. Let's see if anyone else has feedback, but I think this gives much more relevant information to the readers than before. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Koalas provides a familiar pandas DataFrame interface on top of Apache Spark. It enables users to leverage multi-cores on one machine or a cluster of machines to speed up or scale their DataFrame code. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is much better in my opinion. Let's see if anyone else has feedback, but I think this gives much more relevant information to the readers than before. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as well
Thank you, @datapythonista, @WillAyd and @TomAugspurger for your guidance and approval. |
git diff upstream/master -u -- "*.py" | flake8 --diff
I (almost) copied and pasted from its README.md.