Skip to content

DOC: ecosystem.rst: Koalas #26425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2019
Merged

Conversation

HyukjinKwon
Copy link
Contributor

@HyukjinKwon HyukjinKwon commented May 16, 2019

I (almost) copied and pasted from its README.md.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26425 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26425      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46529    46525       -4     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.19% <ø> (ø) ⬆️
#single 41.16% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6e47d...d0063ba. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26425 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26425      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46529    46525       -4     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.19% <ø> (ø) ⬆️
#single 41.16% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6e47d...d0063ba. Read the comment docs.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26425 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26425      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46548    46544       -4     
- Misses       4193     4197       +4
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.7% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263e1a...1b0abec. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you took the description from Koalas documentation, but it sounds more like a sales speech than a useful description (e.g. be more productive when interacting with big data).

Also, I think we can safely assume that users checking this documentation know what pandas is (and probably spark).

Can you please rephrases, being concise on what Koalas does. Also, didn't check Koalas, but I doubt it implements the full pandas API with spark as a backend. Please add what users can expect in terms of stability and completeness of the API.

@HyukjinKwon
Copy link
Contributor Author

Sure, will do. Thanks!

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Koalas provides a familiar pandas DataFrame interface on top of Apache Spark. It enables users to leverage multi-cores on one machine or a cluster of machines to speed up or scale their DataFrame code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datapythonista, how does it looks like?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much better in my opinion. Let's see if anyone else has feedback, but I think this gives much more relevant information to the readers than before. Thanks!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Koalas provides a familiar pandas DataFrame interface on top of Apache Spark. It enables users to leverage multi-cores on one machine or a cluster of machines to speed up or scale their DataFrame code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much better in my opinion. Let's see if anyone else has feedback, but I think this gives much more relevant information to the readers than before. Thanks!

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone May 17, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

@TomAugspurger TomAugspurger merged commit 446d306 into pandas-dev:master May 17, 2019
@HyukjinKwon
Copy link
Contributor Author

Thank you, @datapythonista, @WillAyd and @TomAugspurger for your guidance and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Koalas project in pandas Ecosystem
4 participants