-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove __unicode__ from pyx, etc. files #26416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26416 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 174 174
Lines 50739 50739
==========================================
- Hits 46524 46520 -4
- Misses 4215 4219 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26416 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 174 174
Lines 50739 50739
==========================================
- Hits 46524 46520 -4
- Misses 4215 4219 +4
Continue to review full report at Codecov.
|
The MacOs error in a connection issue, so unrelated. |
Restarted that to be safe. Do we have tests that hit this? IIRC the semantics for Cython don't 100% follow Python when it comes to str / unicode handling even with the language_level being set to 3 in our configuration, so would be good to double check these |
I suspect there won't be any strange Cython interaction. |
thanks @topper-123 |
Removes use of
__unicode__
from the all pyx, pxi pxi.in etc type files.This pattern was almost not used in the non-.py type files.