Skip to content

Remove extraneous brackets #26375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2019
Merged

Remove extraneous brackets #26375

merged 2 commits into from
May 14, 2019

Conversation

deepyaman
Copy link
Contributor

Trivial documentation changes

Dictionary should have one set of brackets (as seen below in documentation example {'a': np.float64, 'b': np.int32}).

Brackets don't make sense around 'w' or 'a'.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26375 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26375      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50703              
==========================================
- Hits        46488    46484       -4     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.19% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 92.13% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e43a4...19f5861. Read the comment docs.

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26375 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26375      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50704       +1     
==========================================
- Hits        46488    46485       -3     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.19% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 92.13% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️
pandas/core/indexes/base.py 96.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e43a4...1698a2f. Read the comment docs.

@WillAyd WillAyd added the Docs label May 13, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone May 13, 2019
@WillAyd WillAyd merged commit 304d8d4 into pandas-dev:master May 14, 2019
@WillAyd
Copy link
Member

WillAyd commented May 14, 2019

Thanks!

@deepyaman deepyaman deleted the patch-1 branch May 14, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants