-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove empty parenteses on class creation #26323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: remove empty parenteses on class creation #26323
Conversation
9523c28
to
388ed3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #26323 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26323 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52297 52297
==========================================
- Hits 48138 48133 -5
- Misses 4159 4164 +5
Continue to review full report at Codecov.
|
looks fine. can you add a rule which checks that we don't have this. |
388ed3a
to
8230f11
Compare
I've added the rule. Could someone verify it works, I'm on Windows and can't run the script. |
8230f11
to
0f22b77
Compare
I checked your original regex, and the one I suggested, and both look to work as intended. FYI - installing git on windows often times will also give you git bash, which would allow you to test out these things (just replace |
FYI: The changes that were introduced into |
Minor clean-up: Some classes are created with a
()
which is not needed.