Skip to content

CLN: remove empty parenteses on class creation #26323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2019

Conversation

topper-123
Copy link
Contributor

Minor clean-up: Some classes are created with a () which is not needed.

@topper-123 topper-123 force-pushed the clean_empty_class_creation branch from 9523c28 to 388ed3a Compare May 9, 2019 06:41
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #26323 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26323      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52291    52291              
==========================================
- Hits        48132    48128       -4     
- Misses       4159     4163       +4
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 93.22% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d024aae...388ed3a. Read the comment docs.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #26323 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26323      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52297    52297              
==========================================
- Hits        48138    48133       -5     
- Misses       4159     4164       +5
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.17%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 93.22% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17247ed...0f22b77. Read the comment docs.

@topper-123 topper-123 changed the title CLN: remove empty class creation parenteseses CLN: remove empty parenteseses class creation May 9, 2019
@topper-123 topper-123 changed the title CLN: remove empty parenteseses class creation CLN: remove empty parenteseses on class creation May 9, 2019
@topper-123 topper-123 changed the title CLN: remove empty parenteseses on class creation CLN: remove empty parenteses on class creation May 9, 2019
@jreback
Copy link
Contributor

jreback commented May 9, 2019

looks fine. can you add a rule which checks that we don't have this.

@topper-123 topper-123 force-pushed the clean_empty_class_creation branch from 388ed3a to 8230f11 Compare May 9, 2019 14:10
@WillAyd WillAyd added this to the 0.25.0 milestone May 9, 2019
@topper-123
Copy link
Contributor Author

I've added the rule. Could someone verify it works, I'm on Windows and can't run the script.

@topper-123 topper-123 force-pushed the clean_empty_class_creation branch from 8230f11 to 0f22b77 Compare May 9, 2019 17:21
@jschendel
Copy link
Member

Could someone verify it works, I'm on Windows and can't run the script.

I checked your original regex, and the one I suggested, and both look to work as intended.

FYI - installing git on windows often times will also give you git bash, which would allow you to test out these things (just replace invgrep with grep).

@jschendel jschendel merged commit ee6b131 into pandas-dev:master May 9, 2019
@topper-123 topper-123 deleted the clean_empty_class_creation branch May 10, 2019 04:50
gfyoung added a commit that referenced this pull request May 10, 2019
@gfyoung
Copy link
Member

gfyoung commented May 10, 2019

FYI: The changes that were introduced into code_checks.sh had some pretty blatant typos and grammar errors. I've corrected them in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants